mender-connect: fix systemd DISTRO_FEATURES handling #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheYoctoJester, start a full client pipeline with:
my commands and optionsYou can prevent me from automatically starting CI pipelines:
You can trigger a client pipeline on multiple prs with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
The mender-connect.service unit should be installed if the resulting distribution is using systemd, and not only if the `mender-systemd` flag is set in `MENDER_FEATURES`. Otherwise installing mender-connect is broken in cases where no full Mender integration is present. Ticket: None Changelog: Title Signed-off-by: Josef Holzmayr <[email protected]>
TheYoctoJester
force-pushed
the
remove_unneccessary_mender_systemd_upstream
branch
from
ada13ec to
a9baa2f
Compare
|
Merging these commits will result in the following changelog entries: Changelogsmeta-mender (remove_unneccessary_mender_systemd_upstream)New changes in meta-mender since master: Bug Fixes
|
|
@mender-test-bot start client pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-1927558916 Build Configuration Matrix
|
|
@mender-test-bot start client pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-1960767182 Build Configuration Matrix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mender-connect.service unit should be installed if the resulting distribution is using systemd, and not only if the
mender-systemdflag is set inMENDER_FEATURES.Otherwise installing mender-connect is broken in cases where no full Mender integration is present.
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff. Also note that the signoff author must match the author of the commit.Description
Please describe your pull request.
Thank you!